-
Notifications
You must be signed in to change notification settings - Fork 2.7k
logformatter: add cleanup tracer log link #24411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@edsantiago PTAL, not sure if this is right but I guess will find out soon enough when I look at logs here |
/lgtm /hold Good to hear that your tracer logs are proving useful! |
/lgtm Shame on me for not even bothering to run the script. It passes syntax check now. |
Shame on me for being unable to use copy+paste correctly :) |
I had a few cases where this is super handy in CI and if I can access the link without one extra click it safes me some time and hopefully makes it more discoverable for other to see how useful it can be sometimes. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Ok link was not working, I think because it was missing the extra |
I had not verified that, but just did so (by cutting-pasting on an existing podman-server.log link). /lgtm |
/hold cancel |
I had a few cases where this is super handy in CI and if I can access the link without one extra click it safes me some time and hopefully makes it more discoverable for other to see how useful it can be sometimes.
Does this PR introduce a user-facing change?